test(api): Add some absorbance reader integration tests #16740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
changed the title
vegano1
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds tests to capture some of the current behavior of the absorbance reader module, as the Python Protocol API simulator sees it. This is regression protection for RQA-3471 / PR #16734.
Test Plan and Hands on Testing
Make sure CI passes.
Review requests
Is all of this captured behavior good and intentional, or is there anything we should mark as something that we want to change, or that we're okay with changing?
Risk assessment
Tests only. No risk to production code.
There's a thread leak inherent to these
tests/protocol_api_integrationtests, sincesimulate.get_protocol_api()doesn't have a.close()method. With every test that we add here, we're risking flakiness in CI if we hit the CI runner's thread limit.